feat: Add all Enterprise MFEs to devstack.#156
Merged
Conversation
Added 3 MFEs: - frontend-app-admin-portal - frontend-app-learner-portal-enterprise - frontend-app-enterprise-checkout Also fix bug where enterprise-subsidy was missing from a list, preventing `make enterprise-subsidy-logs` type commands from working.
pwnage101
force-pushed
the
pwnage101/ENT-10194-0
branch
from
52c0b05 to
ee2c5b9
Compare
pwnage101
commented
Jul 11, 2025
Comment on lines
+78
to
+82
| | `frontend-app-admin-portal`_ | http://localhost:1991 | MFE (React.js) | Extra | | ||
| +-------------------------------------------+-------------------------------------+----------------+--------------+ | ||
| | `frontend-app-learner-portal-enterprise`_ | http://localhost:8734 | MFE (React.js) | Extra | | ||
| +-------------------------------------------+-------------------------------------+----------------+--------------+ | ||
| | `frontend-app-enterprise-checkout`_ | http://localhost:1989 | MFE (React.js) | Extra | |
Member
Author
There was a problem hiding this comment.
Only added these 3 rows.
brobro10000
approved these changes
Jul 11, 2025
iloveagent57
approved these changes
Jul 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds three new enterprise microfrontends to Devstack and fixes a missing entry for enterprise-subsidy, restoring related make commands.
- Added frontend-app-admin-portal, frontend-app-learner-portal-enterprise, and frontend-app-enterprise-checkout across repos, configs, docs, and compose files
- Updated lms.py debug toolbar settings and options.mk to include enterprise-subsidy and the new MFEs
- Extended docker-compose and docker-compose-host definitions for the three MFEs
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repo.sh | Added three new MFE GitHub URLs to non_release_repos and non_release_ssh_repos |
| py_configuration_files/lms.py | Defined ENTERPRISE_CHECKOUT constants and included in debug toolbar lists |
| options.mk | Appended new MFEs to EDX_SERVICES and added enterprise-subsidy to DB_SERVICES |
| docs/service_list.rst | Added table rows and anchors for the three new MFEs |
| docker-compose.yml | Added service definitions for the new MFEs with ports, aliases, and depends_on |
| docker-compose-host.yml | Mounted host volumes and node_modules for the new MFEs |
Comments suppressed due to low confidence (4)
docs/service_list.rst:78
- After extending the table with new entries, verify that the grid separators (the +/- lines) align with the updated column widths so the table renders correctly in RST.
| `frontend-app-admin-portal`_ | http://localhost:1991 | MFE (React.js) | Extra |
docker-compose.yml:1219
- [nitpick] The new microfrontend depends on lms and enterprise-access, but enterprise-subsidy is also required for enterprise checkout flows. Consider adding enterprise-subsidy to the depends_on list.
- enterprise-access
docs/service_list.rst:126
- [nitpick] The other microfrontend anchors reference the openedx org, but this anchor points to edx. Double-check that the repository namespace is correct for consistency.
.. _frontend-app-enterprise-checkout: https://github.com/edx/frontend-app-enterprise-checkout
repo.sh:59
- [nitpick] This clone URL uses the edx GitHub organization, whereas the other microfrontends use openedx. Confirm that the enterprise-checkout repository is intended to live under edx rather than openedx.
"https://github.com/edx/frontend-app-enterprise-checkout.git"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 3 MFEs:
Also fix bug where enterprise-subsidy was missing from a list, preventing
make enterprise-subsidy-logs-esque commands from working.